RFR: 8330647: Two CDS tests fail with -UseCompressedOops and UseSerialGC/UseParallelGC [v3]

[David Holmes]

On Tue, 21 May 2024 20:57:29 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> The following two tests contain `@requires vm.cds.write.archived.java.heap` which implies `UseG1GC && UseCompressedClassPointers`
>> 
>> cds/appcds/cacheObject/ArchiveHeapTestClass.java
>> cds/serviceability/ReplaceCriticalClassesForSubgraphs.java
>> 
>> The tests would fail if options conflicting with `vm.cds.write.archived.java.heap` are specified via the ` -Dtest.cds.runtime.options` property because the options would be added after the `@require` check.
>> 
>> A fix is to check if the ` -Dtest.cds.runtime.options` property contains non-null value and throws a `SkippedException`.
>> 
>> Update:
>> The checking of the ` -Dtest.cds.runtime.options` property is now performed in VMProps.java.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   comments from David H. and @turbanoff

test/jtreg-ext/requires/VMProps.java line 484:

> 482:             if (opt.startsWith(GC_PREFIX) && opt.endsWith(GC_SUFFIX) &&
> 483:                 !opt.equals(G1GC_ENABLED))
> 484:                 return false;

Based on the bug report both of these conditions are needed to be enabled for there to be a problem, but you exclude based on either `-XX:-UseCompressedClassPointers"` or any non-G1 GC. ??

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19274#discussion_r1609255708