RFR: 8332610: Remove unused nWakeups ObjectMonitor [v3]
David Holmes
dholmes at openjdk.org
Wed May 22 05:21:07 UTC 2024
On Tue, 21 May 2024 14:48:15 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Hi,
>>
>> This comment only serves to confuse people, as `nWakeups` is not shared between threads and never read. It is probably meant for debugging (not sure). Let's delete the comment.
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>
> Delete the second nWakeups
Please restore comment, and possibly move them closer to the code the relate to.
Also nit: please change the bug synopsis to "Remove unused nWakeups in ObjectMonitor"
Thanks
-------------
Changes requested by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19326#pullrequestreview-2070117666
More information about the hotspot-runtime-dev
mailing list