RFR: 8330647: Two CDS tests fail with -UseCompressedOops and UseSerialGC/UseParallelGC [v3]

[Calvin Cheung]

On Wed, 22 May 2024 07:54:24 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comments from David H. and @turbanoff
>
> test/jtreg-ext/requires/VMProps.java line 337:
> 
>> 335: 
>> 336:     final String GC_PREFIX = "-XX:+Use";
>> 337:     final String GC_SUFFIX = "GC";
> 
> Maybe move them to the beginning of the file and make them `private static final`? At least add a blank line after them and the following comment.

I've moved them to the beginning of the file.

> test/jtreg-ext/requires/VMProps.java line 473:
> 
>> 471:      * property is compatible with writing Java heap objects into the CDS archive
>> 472:      */
>> 473:     protected boolean isCDSRuntimeOptionsCompatible() {
> 
> Please add braces for all the added `if` statements.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19274#discussion_r1610258193
PR Review Comment: https://git.openjdk.org/jdk/pull/19274#discussion_r1610258270