RFR: 8330647: Two CDS tests fail with -UseCompressedOops and UseSerialGC/UseParallelGC [v4]
Calvin Cheung
ccheung at openjdk.org
Wed May 22 16:03:28 UTC 2024
> The following two tests contain `@requires vm.cds.write.archived.java.heap` which implies `UseG1GC && UseCompressedClassPointers`
>
> cds/appcds/cacheObject/ArchiveHeapTestClass.java
> cds/serviceability/ReplaceCriticalClassesForSubgraphs.java
>
> The tests would fail if options conflicting with `vm.cds.write.archived.java.heap` are specified via the ` -Dtest.cds.runtime.options` property because the options would be added after the `@require` check.
>
> A fix is to check if the ` -Dtest.cds.runtime.options` property contains non-null value and throws a `SkippedException`.
>
> Update:
> The checking of the ` -Dtest.cds.runtime.options` property is now performed in VMProps.java.
Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
@stefank comments
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/19274/files
- new: https://git.openjdk.org/jdk/pull/19274/files/23d69b0d..1c0ef09a
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=19274&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=19274&range=02-03
Stats: 9 lines in 1 file changed: 5 ins; 2 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/19274.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19274/head:pull/19274
PR: https://git.openjdk.org/jdk/pull/19274
More information about the hotspot-runtime-dev
mailing list