RFR: 8332743: Update comment related to JDK-8320522
Coleen Phillimore
coleenp at openjdk.org
Wed May 22 20:01:02 UTC 2024
On Wed, 22 May 2024 19:57:33 GMT, Dan Heidinga <heidinga at openjdk.org> wrote:
>> src/hotspot/share/interpreter/interpreterRuntime.cpp line 232:
>>
>>> 230: // atomic byte write and can be done more than once).
>>> 231: //
>>> 232: // Note: If we have a breakpoint, then we don't rewrite
>>
>> I don't know what this comment is referring to. We don't rewrite the 'new' bytecode into a faster version, which is what I think it is saying. I'd rather see this comment deleted than try to figure out what it might be saying...
>
> Perfect. I was hoping that would be the outcome as I couldn't find anything else that made sense for the rest of the comment either
Even the bit where the "At this point the class might not be fully initialized". It might be creating an instance during initialization, I guess. But I don't see how this comment helps anyone understand anything in this code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19354#discussion_r1610571850
More information about the hotspot-runtime-dev
mailing list