RFR: 8330647: Two CDS tests fail with -UseCompressedOops and UseSerialGC/UseParallelGC [v5]

[David Holmes]

On Thu, 23 May 2024 20:49:12 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> The following two tests contain `@requires vm.cds.write.archived.java.heap` which implies `UseG1GC && UseCompressedClassPointers`
>> 
>> cds/appcds/cacheObject/ArchiveHeapTestClass.java
>> cds/serviceability/ReplaceCriticalClassesForSubgraphs.java
>> 
>> The tests would fail if options conflicting with `vm.cds.write.archived.java.heap` are specified via the ` -Dtest.cds.runtime.options` property because the options would be added after the `@require` check.
>> 
>> A fix is to check if the ` -Dtest.cds.runtime.options` property contains non-null value and throws a `SkippedException`.
>> 
>> Update:
>> The checking of the ` -Dtest.cds.runtime.options` property is now performed in VMProps.java.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add missing braces

Okay that seems fine if either condition disables writing into the CDS archive.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19274#pullrequestreview-2075217332