Integrated: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null

[Matthias Baesken]

On Fri, 24 May 2024 07:32:15 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> When running :tier1 hs tests, the following issue has been reported with ubsan enabled (configure flag --enable-ubsan) the following issue is reported .
> Reason is that gtest forces a call void* no_data_copy = GuardedMemory::wrap_copy(no_data, 0); with 0 length . This leads to a special case for memcpy .
> 
> gtest/GTestWrapper.jtr
> 
> /jdk/src/hotspot/share/memory/guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null
>     #0 0x7f174d684227 in GuardedMemory::wrap_copy(void const*, unsigned long, void const*) /jdk/src/hotspot/share/memory/guardedMemory.cpp:35
>     #1 0x7f174dd210c3 in GuardedMemory_wrap_Test::TestBody() /jdk/test/hotspot/gtest/memory/test_guardedMemory.cpp:146
>     #2 0x7f17526f8d63 in testing::Test::Run() /tools/gtest/googletest-1.14.0/googletest/src/gtest.cc:2687
>     #3 0x7f17526f8d63 in testing::Test::Run() /tools/gtest/googletest-1.14.0/googletest/src/gtest.cc:2677
>     #4 0x7f17526f946d in testing::TestInfo::Run() /tools/gtest/googletest-1.14.0/googletest/src/gtest.cc:2836
>     #5 0x7f1752729ef8 in testing::TestSuite::Run() /tools/gtest/googletest-1.14.0/googletest/src/gtest.cc:3015
>     #6 0x7f1752729ef8 in testing::TestSuite::Run() /tools/gtest/googletest-1.14.0/googletest/src/gtest.cc:2968
>     #7 0x7f175272aec5 in testing::internal::UnitTestImpl::RunAllTests() /tools/gtest/googletest-1.14.0/googletest/src/gtest.cc:5920
>     #8 0x7f17526f0fcf in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /tools/gtest/googletest-1.14.0/googletest/src/gtest.cc:2670
>     #9 0x7f17526f0fcf in testing::UnitTest::Run() /tools/gtest/googletest-1.14.0/googletest/src/gtest.cc:5484
>     #10 0x7f174d8c84d7 in RUN_ALL_TESTS() /tools/gtest/googletest-1.14.0/googletest/include/gtest/gtest.h:2317
>     #11 0x7f174d8c84d7 in runUnitTestsInner /jdk/test/hotspot/gtest/gtestMain.cpp:290
>     #12 0x558be83647d8 in main /jdk/test/hotspot/gtest/gtestLauncher.cpp:40
>     #13 0x7f174734c24c in __libc_start_main (/lib64/libc.so.6+0x3524c) (BuildId: f732026552f6adff988b338e92d466bc81a01c37)

This pull request has now been integrated.

Changeset: be1d374b
Author:    Matthias Baesken <mbaesken at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/be1d374bc54d43aae3b3c1feace22d38fe2156b6
Stats:     3 lines in 1 file changed: 2 ins; 0 del; 1 mod

8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null

Reviewed-by: clanger, mdoerr

-------------

PR: https://git.openjdk.org/jdk/pull/19382