RFR: 8302744: Refactor Hotspot container detection code [v3]
Severin Gehwolf
sgehwolf at openjdk.org
Mon May 27 19:58:02 UTC 2024
On Mon, 27 May 2024 11:29:22 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> This is a really nice cleanup. Some more remarks inline, but its nearing the finish line from my point of view.
Thanks for the review!
> Is the file move of test/hotspot/gtest/runtime/test_cgroupSubsystem_linux.cpp necessary? Difficult to see what changed.
It's not necessary, but tests for the same file have been split between two files which isn't very convenient. What changed is that I've taken existing tests and added some and adjusted to the new interface file parsing functions. It just seems appropriate since we are refactoring the product code anyway. Test coverage is the same (or better).
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19060#issuecomment-2133991294
More information about the hotspot-runtime-dev
mailing list