RFR: 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers [v2]

Severin Gehwolf sgehwolf at openjdk.org
Wed May 29 16:59:04 UTC 2024


On Wed, 22 May 2024 12:01:47 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - More fix-ups after merge
>>  - Fix limit_from_str usages
>>  - Merge branch 'pr/19060' into jdk-8331560-cgroup-controller-delegation
>>  - Fix whitespace
>>  - Refactor cgroup controller code
>
> src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 132:
> 
>> 130:         do_trace_log(hier_memlimit, phys_mem);
>> 131:         return (jlong)hier_memlimit;
>> 132:       }
> 
> Suggestion:
> 
>       if (hier_memlimit < phys_mem) {
>         do_trace_log(hier_memlimit, phys_mem);
>         return (jlong)hier_memlimit;
>       }
>       log_trace(os, container)("Hierarchical Memory Limit is: Unlimited");

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19085#discussion_r1619210028


More information about the hotspot-runtime-dev mailing list