RFR: 8342303: Segfault in update_inherited_vtable: AppCDS, old bytecode, and redefineClasses [v4]

Calvin Cheung ccheung at openjdk.org
Fri Nov 1 05:32:26 UTC 2024


On Fri, 1 Nov 2024 02:13:28 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @dholmes-ora comments - use Class.forName in all cases
>
> test/hotspot/jtreg/runtime/cds/appcds/jvmti/redefineClasses/OldClassAndRedefineClassApp.java line 39:
> 
>> 37:         Instrumentation instrumentation = InstrumentationRegisterClassFileTransformer.getInstrumentation();
>> 38:         System.out.println("INFO: instrumentation = " + instrumentation);
>> 39:         Class<?> c = ClassLoader.getSystemClassLoader().loadClass("Hello");
> 
> Can you use `Class.forName` here too.

Missed that one. Fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21667#discussion_r1825441372


More information about the hotspot-runtime-dev mailing list