RFR: 8343513: Forward declare Thread in mutexLocker.hpp [v2]

David Holmes dholmes at openjdk.org
Mon Nov 4 09:05:30 UTC 2024


On Mon, 4 Nov 2024 08:32:02 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi,
>> 
>> Let's explicitly forward declare `Thread` in `mutexLocker.hpp` instead of including `thread.hpp`. Previously we got the forward declaration from `memory/allocation.hpp`, but let's be explicit about forward declarations being used when we can.
>> 
>> Thanks
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Also requires NMT to actually include thread

Intended change looks okay but there is a typo.

src/hotspot/share/runtime/mutexLocker.hpp line 3:

> 1: /*
> 2:  * Copyright (c) 1997, 2024, Oracle and/or its affiliates. All rights reserved.
> 3:  * DO NO ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.

Unintended edit here

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21868#pullrequestreview-2412510481
PR Review Comment: https://git.openjdk.org/jdk/pull/21868#discussion_r1827397953


More information about the hotspot-runtime-dev mailing list