RFR: 8343321: Bad verify in LockStack::oops_do() [v2]
Joel Sikström
jsikstro at openjdk.org
Mon Nov 4 13:49:05 UTC 2024
> Hello,
>
> Verifying the lock stack's consistency before calling do_oop on the content in the lock stack is unnecessary and may result in a crash. The call to do_oop will (potentially) only change oops already stored in the lock stack, not add or remove anything. If two (or more) oops were equal before doing do_oop on all oops, they will still be the equivalent after the operation. Hence, the consistensy check only needs to happen once, either before or after do_oops, and doing it before might crash, so I propose we remove it.
>
> See exact crash details in the linked issue.
Joel Sikström has updated the pull request incrementally with one additional commit since the last revision:
Add comment on why pre verify is not called/performed
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/21806/files
- new: https://git.openjdk.org/jdk/pull/21806/files/9b299ef0..7a1591e7
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=21806&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=21806&range=00-01
Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/21806.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21806/head:pull/21806
PR: https://git.openjdk.org/jdk/pull/21806
More information about the hotspot-runtime-dev
mailing list