RFR: 8343321: Bad verify in LockStack::oops_do() [v3]

[Stefan Karlsson]

On Mon, 4 Nov 2024 14:11:51 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:

>> Hello,
>> 
>> Verifying the lock stack's consistency before calling do_oop on the content in the lock stack is unnecessary and may result in a crash. The call to do_oop will (potentially) only change oops already stored in the lock stack, not add or remove anything. If two (or more) oops were equal before doing do_oop on all oops, they will still be the equivalent after the operation. Hence, the consistensy check only needs to happen once, either before or after do_oops, and doing it before might crash, so I propose we remove it.
>> 
>> See exact crash details in the linked issue.
>
> Joel Sikström has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Spelling fix

Marked as reviewed by stefank (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21806#pullrequestreview-2413173569