RFR: 8340103: Add internal set_flag function to VMATree [v11]

[Johan Sjölen]

On Mon, 4 Nov 2024 14:44:09 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix incorrect merge
>
> src/hotspot/share/nmt/nmtTreap.hpp line 334:
> 
>> 332:     TreapNode* start = closest_leq(addr);
>> 333:     TreapNode* end = closest_gt(addr);
>> 334:     return Range{start, end};
> 
> I am fine with curly bracket initializer, but does it have to be so dense? What does the styleguide say? I never wrote plain arrays like this, always with spaces interleaved (`int[] i = { 1, 2, 3 };`)

I'd just do curly brace initialization the same way as paren init. I don't think our style guide says anything, but the typical style that I see in C++ code is this dense variant.

Edit: See example code in https://en.cppreference.com/w/cpp/language/aggregate_initialization and search for "uniform init" in https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20994#discussion_r1828902151