RFR: 8340103: Add internal set_flag function to VMATree [v11]

Johan Sjölen jsjolen at openjdk.org
Tue Nov 5 09:19:30 UTC 2024


On Mon, 4 Nov 2024 15:27:44 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix incorrect merge
>
> test/hotspot/gtest/nmt/test_vmatree.cpp line 296:
> 
>> 294:     VMATree tree;
>> 295: 
>> 296:     VMATree::SummaryDiff result = tree.reserve_mapping(0, 500, rd);
> 
> How does using '0' gel with your find_enclosing_range, where NULL for start or end is "did not find"?

Sorry, I don't see what the relevance is for this line of code with the rest of the PR :-). Of course, `nullptr` is a pointer type so can't be passed in as a numerical argument, as opposed to `NULL`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20994#discussion_r1828998029


More information about the hotspot-runtime-dev mailing list