RFR: 8343599: Kmem limit and max values swapped when printing container information
Stefan Johansson
sjohanss at openjdk.org
Wed Nov 6 08:19:28 UTC 2024
On Tue, 5 Nov 2024 15:16:52 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:
> Hi all,
>
> This is a small patch addressing [8343599](https://bugs.openjdk.org/browse/JDK-8343599).
>
> Cheers,
> Sonia
The fix looks good. The comment about order is not a strict requirement, but I think having the same order would be nice.
src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 304:
> 302:
> 303: OSContainer::print_container_helper(st, kmem_usage, "kernel_memory_usage_in_bytes");
> 304: OSContainer::print_container_helper(st, kmem_limit, "kernel_memory_limit_in_bytes");
Looking at the other printouts in `os::Linux::print_container_info(...)` the limit is printed first, followed by usage and max usage. I think it would be good to use that order here as well to be more consistent.
-------------
Marked as reviewed by sjohanss (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21906#pullrequestreview-2417515171
PR Review Comment: https://git.openjdk.org/jdk/pull/21906#discussion_r1830559113
More information about the hotspot-runtime-dev
mailing list