RFR: 8341334: CDS: Parallel relocation [v11]

Aleksey Shipilev shade at openjdk.org
Thu Nov 7 09:12:45 UTC 2024


On Wed, 6 Nov 2024 23:36:41 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Make sure archive workers are shutdown
>>  - Cosmetic changes
>
> src/hotspot/share/cds/archiveUtils.cpp line 444:
> 
>> 442: }
>> 443: 
>> 444: void ArchiveWorkers::start_worker_if_needed() {
> 
> Not sure it matters, but when `_started_workers` is or becomes equal to `_num_workers` we could pass that bit of information on to avoid calling `start_worker_if_needed`. Might avoid a possible burst of contended reads.

I don't think matters. The contention on `_started_workers` is transient, as once we hit `_num_workers`, no updates happen to `_started_workers` anymore.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21302#discussion_r1832313768


More information about the hotspot-runtime-dev mailing list