RFR: 8340103: Add internal set_flag function to VMATree [v11]

Johan Sjölen jsjolen at openjdk.org
Thu Nov 7 10:10:45 UTC 2024


On Mon, 4 Nov 2024 15:09:55 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix incorrect merge
>
> src/hotspot/share/nmt/vmatree.cpp line 245:
> 
>> 243:   position end = MIN2(from + size, range.end->key());
>> 244:   SummaryDiff diff = register_mapping(from, end, type, new_data);
>> 245:   size = size - (end - from);
> 
> Can you please not modify the input parameters, instead use temporary local vars? E.g. "pos" and "remaining".

Sure

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20994#discussion_r1832406631


More information about the hotspot-runtime-dev mailing list