RFR: 8340103: Add internal set_flag function to VMATree [v17]

Thu Nov 7 10:17:20 UTC 2024

On Wed, 6 Nov 2024 10:29:07 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Use size type and size argument name uniformly
>>  - Avoid style discussion by adopting an already accepted style :D
>
> Tests: very nice. Comments inline.

@tstuefe , alright I've cleaned up a bit and fixed the tests. For address holes, the solution is to skip released ranges. I think I want another test for that case, so I'll make sure to get that up. Other than that, the code is pretty good. I guess I could write a small explanation of the algorithm used in `set_tag`, if you find it unintuitive?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20994#issuecomment-2461830167