RFR: 8341094: Clean up relax_verify in ClassFileParser [v2]
Coleen Phillimore
coleenp at openjdk.org
Fri Nov 8 12:25:34 UTC 2024
On Fri, 8 Nov 2024 04:35:53 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rename ClassFileStream::_need_verify to _check_truncation and set based on one call in ClassFileParser.
>
> src/hotspot/share/classfile/verifier.hpp line 54:
>
>> 52: // Return false if the class is loaded by the bootstrap loader,
>> 53: // or if defineClass was called requesting skipping verification
>> 54: // -Xverify:all overrides this value
>
> This comment doesn't describe the new operation of this method.
You're right. There was an old change that made defineClass explicitly disable verification. That code is gone now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21954#discussion_r1834312314
More information about the hotspot-runtime-dev
mailing list