Integrated: 8343321: Bad verify in LockStack::oops_do()

[Joel Sikström]

On Thu, 31 Oct 2024 12:46:26 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:

> Hello,
> 
> Verifying the lock stack's consistency before calling do_oop on the content in the lock stack is unnecessary and may result in a crash. The call to do_oop will (potentially) only change oops already stored in the lock stack, not add or remove anything. If two (or more) oops were equal before doing do_oop on all oops, they will still be the equivalent after the operation. Hence, the consistensy check only needs to happen once, either before or after do_oops, and doing it before might crash, so I propose we remove it.
> 
> See exact crash details in the linked issue.

This pull request has now been integrated.

Changeset: b1a94918
Author:    Joel Sikström <jsikstro at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/b1a9491844a165bf5ae54c50b4f8573bd3f3e24a
Stats:     3 lines in 1 file changed: 2 ins; 0 del; 1 mod

8343321: Bad verify in LockStack::oops_do()

Reviewed-by: stefank, rkennke, coleenp

-------------

PR: https://git.openjdk.org/jdk/pull/21806