RFR: 8340103: Add internal set_flag function to VMATree [v26]
Johan Sjölen
jsjolen at openjdk.org
Tue Nov 12 11:52:34 UTC 2024
> Hi!
>
> The old VirtualMemoryTracker has a method set_reserved_region_type(address, flag). We implement this for the new VMATree implementation by altering the signature slightly to set_reserved_region_type(address, size, flag). This simplifies the implementation greatly for our new data structure and leads to trivial changes for the callers (all callers already know the size).
>
> This PR implements the internal implementation along with tests, but does not change any callers.
>
> I also do a few cleanups:
>
> - Change `Node` to `TreeNode` in tests, we've seen build failures because of this (probably a precompiled headers issue)
> - Add a few `print_on` methods for easy debugging
> - Add a `size` alias, it was a bit confusing that some functions took an argument `position sz`, so changed that to `size sz`
>
> Thanks.
Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
Only assert if success is true
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/20994/files
- new: https://git.openjdk.org/jdk/pull/20994/files/1147c538..5d4d15ea
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=20994&range=25
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=20994&range=24-25
Stats: 4 lines in 1 file changed: 2 ins; 2 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/20994.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20994/head:pull/20994
PR: https://git.openjdk.org/jdk/pull/20994
More information about the hotspot-runtime-dev
mailing list