RFR: 8339288: Improve diagnostic logging runtime/cds/DeterministicDump.java [v3]

[Ioi Lam]

On Tue, 12 Nov 2024 23:36:27 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> The test `DeterministicDump.java` fails frequently since it is sensitive to changes in CDS, and with it's current logging, it is very difficult to diagnose the root cause of these failures. The current output looks like this:
>> 
>> 
>> [First diff: map file #1 (SharedArchiveFile0.map)]
>> [ro region          0x00000008005a2000 - 0x0000000800ea7058   9457752 bytes]
>>  [ro region          0x00000008005a2000 - 0x0000000800ea7058   9457752 bytes]
>>  0x00000008005a2000: @@ Symbol            40 [Ljdk/internal/vm/FillerElement;
>>>0x00000008005a2000:   4c5b0020e72fffff 65746e692f6b646a 2f6d762f6c616e72 6c4572656c6c6946   ../. .[Ljdk/internal/vm/FillerEl
>>  0x00000008005a2020:   00003b746e656d65                                                      ement;..
>>  0x00000008005a2028: @@ Symbol            8 [Z
>> 
>> [First diff: map file #2 (SharedArchiveFile1.map)]
>> [ro region          0x00000008005a2000 - 0x0000000800ea7058   9457752 bytes]
>>  [ro region          0x00000008005a2000 - 0x0000000800ea7058   9457752 bytes]
>>  0x00000008005a2000: @@ Symbol            40 [Ljdk/internal/vm/FillerElement;
>>>0x00000008005a2000:   4c5b00205d54ffff 65746e692f6b646a 2f6d762f6c616e72 6c4572656c6c6946   ..T] .[Ljdk/internal/vm/FillerEl
>>  0x00000008005a2020:   00003b746e656d65                                                      ement;..
>>  0x00000008005a2028: @@ Symbol            8 [Z
>> 
>> Byte #5910530 at line #235268 word #0:
>> SharedArchiveFile0.map: 4c5b0020e72fffff 
>> SharedArchiveFile1.map: 4c5b00205d54ffff 
>> 
>> 
>> This change was verified locally by generating non-deterministic archives and map files.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Corrected mapping from archive byte to line in mapfile

LGTM.

-------------

Marked as reviewed by iklam (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21913#pullrequestreview-2434242536