RFR: 8343889: Test runtime/cds/appcds/redefineClass/RedefineBasicTest.java failed

[Ioi Lam]

On Wed, 13 Nov 2024 19:25:26 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> Fixing the tests under `test/hotspot/jtreg/runtime/cds/appcds/jvmti/redefineClasses` so that the `@run driver RedefineClassHelper` comes before any `@build` command so that subsequent tests can find classes under the` test.lib.helpers` package such as the `ClassFileInstaller` class.
> 
> Revert the changes, which was done via JDK-8342303, to the following tests as the changes are not needed with the current fix.
> 
> test/hotspot/jtreg/runtime/cds/appcds/redefineClass/RedefineBasicTest.java
> test/hotspot/jtreg/runtime/cds/appcds/redefineClass/RedefineRunningMethods_Shared.java
> test/hotspot/jtreg/runtime/logging/RedefineClasses.java
> 
> 
> This change also adds `@requires vm.cds` to the tests so it also fixes JDK-8344046.
> 
> Testing:
> - passed tiers 1, 4 tests

LGTM. I think the underlying issue is jtreg has the tendency of placing class files in unpredictable locations (e.g., [CODETOOLS-7902847](https://bugs.openjdk.org/browse/CODETOOLS-7902847)). So unfortunately the only way to fix that is a whack-a-mole approach.

-------------

Marked as reviewed by iklam (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22085#pullrequestreview-2434279008