Integrated: 8339288: Improve diagnostic logging runtime/cds/DeterministicDump.java

Matias Saavedra Silva matsaave at openjdk.org
Wed Nov 13 23:22:14 UTC 2024


On Tue, 5 Nov 2024 18:36:01 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> The test `DeterministicDump.java` fails frequently since it is sensitive to changes in CDS, and with it's current logging, it is very difficult to diagnose the root cause of these failures. The current output looks like this:
> 
> 
> [First diff: map file #1 (SharedArchiveFile0.map)]
> [ro region          0x00000008005a2000 - 0x0000000800ea7058   9457752 bytes]
>  [ro region          0x00000008005a2000 - 0x0000000800ea7058   9457752 bytes]
>  0x00000008005a2000: @@ Symbol            40 [Ljdk/internal/vm/FillerElement;
>>0x00000008005a2000:   4c5b0020e72fffff 65746e692f6b646a 2f6d762f6c616e72 6c4572656c6c6946   ../. .[Ljdk/internal/vm/FillerEl
>  0x00000008005a2020:   00003b746e656d65                                                      ement;..
>  0x00000008005a2028: @@ Symbol            8 [Z
> 
> [First diff: map file #2 (SharedArchiveFile1.map)]
> [ro region          0x00000008005a2000 - 0x0000000800ea7058   9457752 bytes]
>  [ro region          0x00000008005a2000 - 0x0000000800ea7058   9457752 bytes]
>  0x00000008005a2000: @@ Symbol            40 [Ljdk/internal/vm/FillerElement;
>>0x00000008005a2000:   4c5b00205d54ffff 65746e692f6b646a 2f6d762f6c616e72 6c4572656c6c6946   ..T] .[Ljdk/internal/vm/FillerEl
>  0x00000008005a2020:   00003b746e656d65                                                      ement;..
>  0x00000008005a2028: @@ Symbol            8 [Z
> 
> Byte #5910530 at line #235268 word #0:
> SharedArchiveFile0.map: 4c5b0020e72fffff 
> SharedArchiveFile1.map: 4c5b00205d54ffff 
> 
> 
> This change was verified locally by generating non-deterministic archives and map files.

This pull request has now been integrated.

Changeset: 3b283543
Author:    Matias Saavedra Silva <matsaave at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3b283543c33df8c225e10b9186b7bc3cefd1a347
Stats:     151 lines in 2 files changed: 139 ins; 0 del; 12 mod

8339288: Improve diagnostic logging runtime/cds/DeterministicDump.java

Reviewed-by: ccheung, iklam

-------------

PR: https://git.openjdk.org/jdk/pull/21913


More information about the hotspot-runtime-dev mailing list