Integrated: 8343889: Test runtime/cds/appcds/redefineClass/RedefineBasicTest.java failed

Calvin Cheung ccheung at openjdk.org
Thu Nov 14 17:55:33 UTC 2024


On Wed, 13 Nov 2024 19:25:26 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> Fixing the tests under `test/hotspot/jtreg/runtime/cds/appcds/jvmti/redefineClasses` so that the `@run driver RedefineClassHelper` comes before any `@build` command so that subsequent tests can find classes under the` test.lib.helpers` package such as the `ClassFileInstaller` class.
> 
> Revert the changes, which was done via JDK-8342303, to the following tests as the changes are not needed with the current fix.
> 
> test/hotspot/jtreg/runtime/cds/appcds/redefineClass/RedefineBasicTest.java
> test/hotspot/jtreg/runtime/cds/appcds/redefineClass/RedefineRunningMethods_Shared.java
> test/hotspot/jtreg/runtime/logging/RedefineClasses.java
> 
> 
> This change also adds `@requires vm.cds` to the tests so it also fixes JDK-8344046.
> 
> Testing:
> - passed tiers 1, 4 tests

This pull request has now been integrated.

Changeset: 4d4951a4
Author:    Calvin Cheung <ccheung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/4d4951a4420cf4a9a3bce88d8532055005cff289
Stats:     13 lines in 6 files changed: 3 ins; 4 del; 6 mod

8343889: Test runtime/cds/appcds/redefineClass/RedefineBasicTest.java failed
8344046: Tests under cds/appcds/jvmti/redefineClasses should have @requires vm.cds

Reviewed-by: iklam, matsaave

-------------

PR: https://git.openjdk.org/jdk/pull/22085


More information about the hotspot-runtime-dev mailing list