RFR: 8330606: Redefinition doesn't but should verify the new klass [v2]

[Chris Plummer]

On Thu, 14 Nov 2024 21:31:53 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineVerifyError.java line 124:
>> 
>>> 122:         try {
>>> 123:             RedefineClassHelper.redefineClass(verifyErrorMirror, dump());
>>> 124:             VerifyError err = new VerifyError("verify me now");
>> 
>> Which of these two lines are expected to throw a VerifyError?
>> 
>> Is the VerifyError because you can't redefine VerifyError, or is there something invalid about the how the class is redefined?
>
> We call the verifier during redefinition with the 'true' parameter, so the redefinition will throw VerifyError when it's loading the new class file version.  There's a broken stackmap in the new version of this VerifyError class (ie. I asmifyied it and commented out something in it).  I updated the test with some comments.

Ok. You got rid of the `new VerifyError()`, which is what I figured my next request was going to be. :)

The test looks fine. I don't really have the background to review the native code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22116#discussion_r1842930758