RFR: 8342504: Remove NMT header and footer canaries [v2]

[Johan Sjölen]

On Mon, 18 Nov 2024 14:04:43 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> No, not anymore. The canaries are how we perform memory corruption checks. As mentioned in the PR description, I believe that since we have introduced UBSan and ASan it is no longer necessary for NMT to be able to detect memory corruption.
>
> I would like to caution that this would trash the ability to check for corruption for platforms that don't support ubsan and asan. Windows, with the VC compiler, comes to mind (Actually, even the Windows/gcc Port cannot use ubsan and asan either, since the sanitizers haven't been properly ported for Windows in general)

Thanks for the input, Julian. It seems like both ubsan and asan are available on Clang for Windows (8.1+ for asan), so we'd have a way of getting memory corruption detection on those platforms also.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21560#discussion_r1846812288