RFR: 8342089: Require --enable-native-access to be the same between CDS dump time and run time [v3]
Matias Saavedra Silva
matsaave at openjdk.org
Fri Nov 22 20:04:25 UTC 2024
On Fri, 22 Nov 2024 19:52:03 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed copyright
>
> src/hotspot/share/classfile/modules.cpp line 698:
>
>> 696: st.print("%s%s", prefix, m);
>> 697: last_string = m;
>> 698: prefix = ",";
>
> Why did you change this back to ","?
Including the "\n" causes the log messages to be a bit awkward, I think using a comma keeps it clear and on one line.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22305#discussion_r1854583631
More information about the hotspot-runtime-dev
mailing list