RFR: 8344821: Test CheckDefaultArchiveFile.java fails if classes_coh.jsa is not present
David Holmes
dholmes at openjdk.org
Tue Nov 26 00:52:38 UTC 2024
On Mon, 25 Nov 2024 23:45:55 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
> JDK image built by Oracle does not include the CDS archives for compact object headers. This fix throws a SkippedException if UseCompactObjectHeaders is enabled and the default CDS archive for COH is not present.
I think I agree with what @iklam said in JBS - this test seems to have no purpose now. I can't tell what exactly it is trying to check for. Depending on the runtime flags the name of the expected "default archive" is different, but it is not mandatory to have an archive file present - unless it is the plain classes.jsa one ?
And what does `Platform.isDefaultCDSArchiveSupported()` actually mean now we have the optional COH archive?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22374#issuecomment-2499330266
More information about the hotspot-runtime-dev
mailing list