RFR: 8344913: Improve -Xlog:cds+map+oop logging for Java mirrors [v3]

Ioi Lam iklam at openjdk.org
Tue Nov 26 06:23:52 UTC 2024


On Mon, 25 Nov 2024 04:53:44 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Renamed to print_oop_info_cr()
>
> src/hotspot/share/cds/archiveBuilder.cpp line 1461:
> 
>> 1459:   //     0x00000007ffc7e840 (0xfff8fd08) java.lang.Class
>> 1460:   //     0x00000007ffc000f8 (0xfff8001f) [B length: 11
>> 1461:   static void print_oop_with_requested_addr_cr(outputStream* st, oop source_oop, bool print_addr = true, bool print_aot_init = false) {
> 
> Pre-existing but it seems very odd to me to have a function called `print_oop_with_requested_addr` and then have a parameter to control whether we print the addr.

I changed the function name to `print_oop_info_cr()` and added comments about whether address(es) are printed, and in what format.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22345#discussion_r1857866065


More information about the hotspot-runtime-dev mailing list