RFR: 8344913: Improve -Xlog:cds+map+oop logging for Java mirrors [v3]

Ioi Lam iklam at openjdk.org
Tue Nov 26 06:23:52 UTC 2024


On Mon, 25 Nov 2024 19:29:47 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Renamed to print_oop_info_cr()
>
> src/hotspot/share/cds/archiveBuilder.cpp line 1297:
> 
>> 1295:       if (source_oop != nullptr) {
>> 1296:         // This is a regular oop that got archived.
>> 1297:         print_oop_with_requested_addr_cr(&st, source_oop, false, true);
> 
> Now that the function takes two boolean args. I think it is good to add comments on those boolean args.

I added the comment about what the first `false` parameter means. I also removed the second parameter as suggested by David.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22345#discussion_r1857866475


More information about the hotspot-runtime-dev mailing list