RFR: 8344821: Test CheckDefaultArchiveFile.java fails if classes_coh.jsa is not present [v2]

Ioi Lam iklam at openjdk.org
Tue Nov 26 06:35:47 UTC 2024


On Tue, 26 Nov 2024 04:12:32 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> JDK image built by Oracle does not include the CDS archives for compact object headers. This fix throws a SkippedException if UseCompactObjectHeaders is enabled and the default CDS archive for COH is not present.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   delete the test

There are also other test cases that call `Platform.isDefaultCDSArchiveSupported()`. I  think these probably need to be cleaned up / removed (in separate RFE?)


./lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java:                "areCustomLoadersSupportedForCDS", "isDefaultCDSArchiveSupported",
./jdk/tools/jlink/plugins/CDSPluginTest.java:        if (!Platform.isDefaultCDSArchiveSupported())
./hotspot/jtreg/runtime/cds/CheckSharingWithDefaultArchive.java:        if (!Platform.isDefaultCDSArchiveSupported()) {
./hotspot/jtreg/runtime/cds/CheckDefaultArchiveFile.java:            if (Platform.isDefaultCDSArchiveSupported()) {
./hotspot/jtreg/runtime/cds/CheckDefaultArchiveFile.java:            if (Platform.isDefaultCDSArchiveSupported()) {
./hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineSharedClass.java:        if (!Platform.isDefaultCDSArchiveSupported()) {
./lib/jdk/test/lib/Platform.java:    public static boolean isDefaultCDSArchiveSupported() {

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22374#issuecomment-2499775786


More information about the hotspot-runtime-dev mailing list