RFR: 8344935: [ubsan]: javaThread.hpp:1241:52: runtime error: load of value 9831830, which is not a valid value for type 'freeze_result'

[Richard Reingruber]

On Tue, 26 Nov 2024 09:06:35 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Btw should we have another value e.g. `freeze_initialized` for the constructor ? I took `freeze_ok` but maybe this is not representing well the init state ?

I don't think that's needed. Nice thing about initializing with `freeze_ok` is that assertions already check that the value is not equal to `freeze_ok` when it is read (see comment above). So better revert to initializing with `freeze_ok`.

It is easy to forget setting `_last_freeze_fail_result` therefore the callers of `freeze_internal` should assert that it has been set. I'd suggest to do it as in this commit: https://github.com/openjdk/jdk/commit/99e6240ff1350bf732d89dedd2a221368701a055

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22361#issuecomment-2500220232