RFR: 8342089: Require --enable-native-access to be the same between CDS dump time and run time [v6]

[Matias Saavedra Silva]

On Tue, 26 Nov 2024 01:35:20 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/runtime/arguments.hpp line 466:
>> 
>>> 464:   static bool is_internal_module_property(const char* option);
>>> 465:   static bool is_non_cds_compatible_internal_module_property(const char* property);
>>> 466:   static bool internal_module_property_helper(const char* property, bool check_for_cds);
>> 
>> Instead of `bool check_for_cds`, how about `bool check_all`?
>> If you choose to rename that, you'll need to change the checking of the bool inside the function and also flip the bool value at the callsites.
>
> I don't think `check_all` is a good name -- it's not clear what the opposite of `check_all` means.
> 
> `internal_module_property_helper()` should be a private function whose definition. It should be used only by arguments.cpp and not be a public function.

I agree with Ioi here. I'll make `internal_module_property_helper()` private and use the method name suggested above.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22305#discussion_r1858788726