RFR: 8344824: CDS dump crashes when member_method of a lambda proxy is null [v2]

Matias Saavedra Silva matsaave at openjdk.org
Tue Nov 26 15:59:41 UTC 2024


On Sat, 23 Nov 2024 00:27:41 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Since [JDK-8335583](https://bugs.openjdk.org/browse/JDK-8335583), we encode 64-bit pointers used by `RunTimeLambdaProxyClassKey` into 32-bit offsets. However, we didn't handle the cases where some of the pointers could be null.
>> 
>> In this PR, I have added an `or_null` variant of the functions that deal with pointer-to-offset encoding. The `or_null` variant allows an `nullptr` to be encoded with the 32-bit value of `0`.
>> 
>> I also renamed some of the functions to improve readability.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Excluded runtime/cds/appcds/LambdaInvokeVirtual.java from hotspot_appcds_dynamic test group

LGTM!

-------------

Marked as reviewed by matsaave (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22313#pullrequestreview-2461986040


More information about the hotspot-runtime-dev mailing list