RFR: 8344822: CDS BulkLoaderTest.java#dynamic fails with COH [v2]

Ioi Lam iklam at openjdk.org
Wed Nov 27 22:35:22 UTC 2024


> Creating a dynamic CDS archive (with `-XX:ArchiveClassesAtExit=<foo>.jsa`) requires that the current JVM process is using a static archive (which is usually the default CDS archive included in the JDK). The tests fails because the JVM is executed with `-XX:+UseCompactObjectHeaders`, but the JDK doesn't include a default CDS archive that's compatible with such VM options.
> 
> The fix is to detect for this situation, and create a temporary static archive to be used by the test.
> 
> Unfortunately this detection requires WhiteBox, so all test cases that use `CDSAppTester` with `@run ... DYNAMIC` need to be modified to add the appropriate jtreg tags.

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into 8344822-BulkLoaderTest.java-fails-with-coh
 - added more comments
 - CDS BulkLoaderTest.java#dynamic fails with COH

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22403/files
  - new: https://git.openjdk.org/jdk/pull/22403/files/8bd8d37b..7570629b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22403&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22403&range=00-01

  Stats: 3340 lines in 87 files changed: 1655 ins; 1002 del; 683 mod
  Patch: https://git.openjdk.org/jdk/pull/22403.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22403/head:pull/22403

PR: https://git.openjdk.org/jdk/pull/22403


More information about the hotspot-runtime-dev mailing list