Integrated: 8340103: Add internal set_flag function to VMATree
Johan Sjölen
jsjolen at openjdk.org
Thu Nov 28 13:17:52 UTC 2024
On Fri, 13 Sep 2024 10:12:36 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
> Hi!
>
> The old VirtualMemoryTracker has a method set_reserved_region_type(address, flag). We implement this for the new VMATree implementation by altering the signature slightly to set_reserved_region_type(address, size, flag). This simplifies the implementation greatly for our new data structure and leads to trivial changes for the callers (all callers already know the size).
>
> This PR implements the internal implementation along with tests, but does not change any callers.
>
> I also do a few cleanups:
>
> - Change `Node` to `TreeNode` in tests, we've seen build failures because of this (probably a precompiled headers issue)
> - Add a few `print_on` methods for easy debugging
> - Add a `size` alias, it was a bit confusing that some functions took an argument `position sz`, so changed that to `size sz`
>
> Thanks.
This pull request has now been integrated.
Changeset: 1e086b1d
Author: Johan Sjölen <jsjolen at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/1e086b1d7305769b59271e2fa428c003216dd52a
Stats: 367 lines in 4 files changed: 353 ins; 1 del; 13 mod
8340103: Add internal set_flag function to VMATree
Reviewed-by: stuefe, azafari, gziemski
-------------
PR: https://git.openjdk.org/jdk/pull/20994
More information about the hotspot-runtime-dev
mailing list