RFR: 8344831: [REDO] CDS: Parallel relocation [v4]

[Aleksey Shipilev]

On Thu, 28 Nov 2024 02:44:51 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Atomicity improvements
>
> This seems okay, though I wonder if there is not a more well-established "smart ptr" style pattern for managing the lifecycle via a wrapper where last thread out does the delete?
> 
> Anyway clicking approve.
> 
> Thanks

Thanks @dholmes-ora! I would appreciate if anyone could run this through Oracle test suite that caught the original regressions.

Pinging the original reviewers: @iklam, @adinn, @tstuefe, @cl4es -- for attention :)

> src/hotspot/share/cds/archiveUtils.cpp line 492:
> 
>> 490:   }
>> 491: 
>> 492:   OrderAccess::fence();
> 
> What is the fence for?

Mostly hygiene on exit path. It is not, strictly speaking, necessary after we did the semaphore.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22369#issuecomment-2506174465
PR Review Comment: https://git.openjdk.org/jdk/pull/22369#discussion_r1862233266