RFR: 8345012: os::build_agent_function_name potentially wastes a byte when allocating the buffer [v3]

[David Holmes]

On Thu, 28 Nov 2024 12:50:37 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> That kind of change in functionality is not a part of this PR.  Plus it is a moot point as we would never get a native OOM during VM init in any realistic circumstances.
>
> Sorry, you are right - I should have not responded this late at night :) If we are going to abort the VM we should at least report the correct reason.

Nope I retract that again. This code is used for both command-line agents and dynamically attaching agents, so this may not happen during init, so we do not want to abort on OOM.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22404#discussion_r1862812275