RFR: 8345102: [s390x/ppc] ShowRegistersOnAssertTest.java fails after 8343756 [v3]

[Martin Doerr]

On Fri, 29 Nov 2024 10:53:05 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/ErrorHandling/ShowRegistersOnAssertTest.java line 87:
>> 
>>> 85:                 pattern = new Pattern[] { Pattern.compile("Registers:"), Pattern.compile("pc =.*")};
>>> 86:             } else {
>>> 87:                 pattern = new Pattern[] { Pattern.compile("Registers:"), null };
>> 
>> Doesn't `null` cause other NullPointerExceptions? Did you test it?
>
> I only tested on s390x and my team mate tested on PPC. Both of these platforms are okay. For rest neither I have hardware access nor I have hs_err file info. So It should give them the same result  pass/fail as it was giving before this change.

I disagree. The code should not crash. It can easily be tested by commenting out the platform case of your choice above.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22427#discussion_r1863359253