RFR: 8345102: [s390x/ppc] ShowRegistersOnAssertTest.java fails after 8343756 [v3]

[Martin Doerr]

On Fri, 29 Nov 2024 11:18:58 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> It should work if you remove ", null".
>
> I agree with your point that if platform check is not defined then test will crash.
> 
>> The code should not crash.
> 
> Could you suggest any other way through which, on other platforms, test will not crash instead it will notify that information is missing and test should be updated according to their platform ? Because what I see is that the whole point of null being there was to check that "registers" info is not printed.
> 
> Maybe we can ping other maintainers here and they can verify it passes and if not then add the check with this PR.

You can ask the maintainers. But I don't think it is important. I could live with checking for "Registers:" only.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22427#discussion_r1863377804