RFR: 8338883: Show warning when CreateCoredumpOnCrash set, but core dump will not happen [v12]

[Gerard Ziemski]

On Wed, 2 Oct 2024 00:44:43 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   clear warning on Win
>
> src/hotspot/os/windows/os_windows.cpp line 1322:
> 
>> 1320:         }
>> 1321:       } else {
>> 1322:         // For now on Windows, there is no more checks that we can do
> 
> Suggestion:
> 
>         // For now on Windows, there are no more checks that we can do.

Fixed

> test/hotspot/jtreg/runtime/ErrorHandling/CreateCoredumpOnCrash.java line 1:
> 
>> 1: /*
> 
> Java code indent is 4 not 2 - please reformat.

Fixed.

> test/hotspot/jtreg/runtime/ErrorHandling/CreateCoredumpOnCrash.java line 39:
> 
>> 37: import jdk.internal.misc.Unsafe;
>> 38: 
>> 39: import java.lang.Runtime;
> 
> This is not needed

Fixed.

> test/hotspot/jtreg/runtime/ErrorHandling/CreateCoredumpOnCrash.java line 79:
> 
>> 77:         oa.shouldNotHaveExitValue(0);
>> 78: 
>> 79:         // Do "ulimit -c 0" last, as once we decrease it, we cannot increase it
> 
> But you are running each test in a new shell.

Good catch. The comment is a leftover from earlier prototypes.

I will remove it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20734#discussion_r1784807908
PR Review Comment: https://git.openjdk.org/jdk/pull/20734#discussion_r1784806738
PR Review Comment: https://git.openjdk.org/jdk/pull/20734#discussion_r1784807302
PR Review Comment: https://git.openjdk.org/jdk/pull/20734#discussion_r1784805216