RFR: 8341091: CDS: Segmented roots array misses roots [v2]

[Aleksey Shipilev]

On Wed, 2 Oct 2024 15:54:05 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Tighthen the comment
>>  - Merge branch 'master' into JDK-8341091-cds-segmented-roots-bugs
>>  - Fix
>
> src/hotspot/share/cds/archiveHeapLoader.cpp line 379:
> 
>> 377: 
>> 378:     // The heap roots are stored in one or more segments that are laid out consecutively.
>> 379:     // The byte size of each segment (except for the last one) is max_size.
> 
> Comment here mentions `max_size` but that doesn't exist any more.

Thanks! I tightened up the comment a bit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21221#discussion_r1784832878