RFR: 8341334: CDS: Parallel pretouch and relocation [v3]

Aleksey Shipilev shade at openjdk.org
Wed Oct 2 16:54:42 UTC 2024


On Wed, 2 Oct 2024 16:23:58 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Do not create worker threads too early: Mac/Windows are not yet ready to use Semaphores
>
> src/hotspot/share/cds/archiveUtils.hpp line 346:
> 
>> 344:   // to take 1/4 CPUs to provide decent parallelism without letting workers
>> 345:   // stumble over each other.
>> 346:   static constexpr int cpus_per_worker = 4;
> 
> Could these static constexpr values maybe be declared either with am ALL_CAPS_NAME or _leading_underscore. They currently look like locals/params at point of use.

Done in new commit. (I'll push all them soon.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21302#discussion_r1784898861


More information about the hotspot-runtime-dev mailing list