RFR: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64

Wed Oct 2 18:42:36 UTC 2024

On Tue, 1 Oct 2024 18:38:33 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> Add missing StoreLoad fences in handshaking code to match safepoint code.  Thanks to @pchilano for finding this bug.
> 
> Tested with tier1-4 and tier8 which has Kitchensink in it.

Yea, I think there maybe some more issues.
For exampel having stores slipping into HandshakeState::process_by_self after the MutexLocker doesn't give me a good feeling. I would suggest doing a more elaborate fix. Maybe a stricter version of the mutex so try_lock and lock releases?
I can look more at this next week.

(I don't mind if you choose to ship this as is)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21295#issuecomment-2389441207