RFR: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64

[Coleen Phillimore]

On Wed, 2 Oct 2024 22:45:52 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> src/hotspot/share/runtime/handshake.cpp line 260:
>> 
>>> 258:       SystemMemoryBarrier::emit();
>>> 259:     } else {
>>> 260:       OrderAccess::fence(); // storestore|storeload, global state -> local state
>> 
>> The comment is somewhat confusing as a fence is logically all four of the storeload etc barriers not just the pair listed. I suggest just removing the comment. And yes I realize this was copied from the safepoint code (but it also has a comment on the emit that is not here, so it is okay if they differ).
>
> +1 on removing this comment. Also seems global state refers to _state for the safepoint code which doesn't apply here.

I copied this from the safepoint case.  Will remove.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21295#discussion_r1786083079