RFR: 8338883: Show warning when CreateCoredumpOnCrash set, but core dump will not happen [v2]

Gerard Ziemski gziemski at openjdk.org
Tue Oct 8 21:44:02 UTC 2024


On Thu, 29 Aug 2024 01:00:35 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - copyright year
>>  - refactor core dump check code and separate checking from creating core file
>
> BTW see the 2015 code review thread for more info on current functions and naming, in particular Thomas's summary here:
> https://mail.openjdk.org/pipermail/hotspot-runtime-dev/2015-March/014356.html

@dholmes-ora @jdksjolen Can you please take a look one last time?

- I relaxed the testing a bit to avoid `get_core_path()` which take precedence over the ulimit.
- Added `@requires vm.flagless` since we launch some of our test directly
- Updated copyright year

Thank you!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20734#issuecomment-2400872435


More information about the hotspot-runtime-dev mailing list