RFR: 8338883: Show warning when CreateCoredumpOnCrash set, but core dump will not happen [v2]

[Gerard Ziemski]

On Thu, 29 Aug 2024 01:00:35 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - copyright year
>>  - refactor core dump check code and separate checking from creating core file
>
> BTW see the 2015 code review thread for more info on current functions and naming, in particular Thomas's summary here:
> https://mail.openjdk.org/pipermail/hotspot-runtime-dev/2015-March/014356.html

> > @dholmes-ora @jdksjolen Can you please take a look one last time?
> > ```
> > * Use `sh` to execute `ulimit -c`
> > 
> > * I relaxed the testing a bit to avoid `get_core_path()` which take precedence over the ulimit
> > 
> > * Added `@requires vm.flagless` since we launch some of our test directly
> > 
> > * Updated copyright year
> > ```
> > 
> > 
> >     
> >       
> >     
> > Thank you!
> 
> I'm a bit surprised that we need to use `sh` for running `ulimit`, as `ulimit` should just be a binary present on the `PATH`. Anyway, this is still OK to me.

Thank you for the review.

I looked into `ulimit` and it seems to be a built-in function of a shell:


# cat /usr/bin/ulimit
#!/bin/sh
# $FreeBSD$
# This file is in the public domain.
builtin `echo ${0##*/} | tr [:upper:] [:lower:]` ${1+"$@"}

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20734#issuecomment-2402523487