RFR: 8339289: Parameter size mismatch between client and VM sides of the Attach API - Windows [v4]
Serguei Spitsyn
sspitsyn at openjdk.org
Wed Oct 16 00:07:11 UTC 2024
On Tue, 15 Oct 2024 22:31:46 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
>> The fix improves Attch API protocol and implements updated protocol on windows; shared code is ready to implement updated protocol support on other platforms.
>> More detailed explanations on the 1st comment.
>>
>> Testing: tier1,tier2,tier3,tier4,hs-tier5-svc
>> manually tested backward compatibility (old tools can attach to current VMs, current tools can attach to older VMs) on Windows with jdk21u and jdk8u.
>
> Alex Menkov has updated the pull request incrementally with two additional commits since the last revision:
>
> - updated comment
> - feedback
Thank you for the updates. Looks good.
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20782#pullrequestreview-2370886982
More information about the hotspot-runtime-dev
mailing list